search

mapzen / mapzen-www-places

Mapzen. It's full of places.
3 stars 9 forks source link

Where does mapzen.whosonfirst.placetypes come from? #24

Closed migurski closed 8 years ago

migurski commented 8 years ago

I see it imported in server.py, but I can’t find a mention in the various installation scripts.

thisisaaronland commented 8 years ago

Oh yeah, those need to be updated. That got added yesterday...

easy_install https://github.com/whosonfirst/py-mapzen-whosonfirst-placetypes/tarball/master

thisisaaronland commented 8 years ago

That is now included as part of the setup-dependencies.sh script.

migurski commented 8 years ago

Great! Can I recommend pip instead of easy_install?

thisisaaronland commented 8 years ago

My understanding is that pip expects scripts, etc. to be laid out in very specific ways that don't warrant the time to refactor right now (maybe when we support Python 3 for all the things).

If I am wrong about that then I just need pointers for what to do.

migurski commented 8 years ago

It’s a drop-in replacement the way you're using it. Replace every instance of easy_install with pip install to reap the benefits of an extra half-decade of development:

pip install https://github.com/whosonfirst/py-mapzen-whosonfirst-placetypes/tarball/master
thisisaaronland commented 8 years ago

What are these benefits?

migurski commented 8 years ago

It’ll make it easier to select a Python version on Circle, so that we can connect this to Precog. Circle uses Virtualenv’s, which might work with easy_install but basically nobody tests with it anymore.

thisisaaronland commented 8 years ago

Done. I note with interest that apt still refers to pip as the "alternative package manager" for Python.

migurski commented 8 years ago

Heh. I think those descriptions are forever.