implementing hanbyuls fallbacktile

mapzen / metro-extracts

DEPRECATED. See readme for alternative ways to get "city-sized chunks" of OpenStreetMap data

ISC License

25 stars 27 forks source link

implementing hanbyuls fallbacktile #182

Closed binx closed 8 years ago

binx commented 8 years ago

closes #181

migurski commented 8 years ago

What's the best way to test this?

binx commented 8 years ago

erg, this is not working

@hanbyul-here I tried this in IE11 (browserstack) and got the below image, did I mess up the syntax? screen shot 2016-07-20 at 3 49 42 pm

hanbyul-here commented 8 years ago

were you trying to see fallback works? IE 11 supports WebGL, so fallback shouldn't work. Based on attribution (worked) , I wonder tiles were being just slowly loaded? If you can check developer's console, it will help me figure out a lot.

binx commented 8 years ago

@hanbyul-here aha! ok it was just slow to load, I went back and tiles did come in.

re: tilefallback, I do see it working in an iphone5. One thing, the default attribution is still being added on the fallback tiles. Do you think we should fix this in mapzen.js, or do some sort of webGL check on our end to remove the default attribution?

screen shot 2016-07-21 at 9 27 48 am

hanbyul-here commented 8 years ago

Did you try attributionText api? https://github.com/mapzen/mapzen.js#api

While it is true that we need to polish attribution more, not using Tangram doesn't always mean it is not using Mapzen product, so I also wonder about what can be the best way. In your specific case, I wonder OSM attribution need to happen two times? Maybe we can skip one from fallback one, but I am not really confident about attribution so please talk with @rmglennon or @migurski about this.