mapzen / styleguide

A living styleguide powering the Mapzen brand (TM)
https://mapzen.com/common/styleguide
MIT License
13 stars 14 forks source link

ditched gulpif #546

Closed hanbyul-here closed 7 years ago

hanbyul-here commented 7 years ago

sourcemap was being shipped in production 😢 fixed it

rfriberg commented 7 years ago

Is publishing source maps on an open source project really all that bad? We don't include any sensitive information (that wouldn't be easily available via this github repo anyway). And I believe the http request to grab the source map only happens when devtools is open, so it shouldn't affect general load times. Are there other concerns I'm missing?

(👍 on dropping gulp-if!)

hanbyul-here commented 7 years ago

@rfriberg oh you are right. Before we didn't separate the sourcemap file from the css file so it used to make huge bundle of sourcemap and css. I didn't catch that this problem was handled before by separting sourcemap. You got good points and I will just update ditch gulpif