search

mapzen / ui

1 stars 4 forks source link

Override components hidden when iframed #29

Closed louh closed 8 years ago

louh commented 8 years ago

Search and locate-me are automatically hidden when we're in an iframe. Sometimes this is not desirable, e.g. when embedded into a blog post or page where the demo requires interaction. (See Indy's "Where the streets have no name.") Let's preserve the current assumption for the drop-in use case, but provide a way to override this behavior. (Idea: option { forceDisplay: true })

louh commented 8 years ago

cc @meetar Is this the thing you were planning to work on for @IndyHurt ? I think I might have forgotten this issue was opened.

meetar commented 8 years ago

Yep! I was looking at this yesterday, trying to figure out how to pass options to the other components. I assume I'll need to export them as self-instantiating modules, the way the bug is now?

On Wed, Apr 27, 2016 at 5:55 PM, Lou Huang notifications@github.com wrote:

cc @meetar https://github.com/meetar Is this the thing you were planning to work on for @IndyHurt https://github.com/IndyHurt ? I think I might have forgotten this issue was opened.

— You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub https://github.com/mapzen/ui/issues/29#issuecomment-215241937

louh commented 8 years ago

This issue was moved to mapzen/scarab#5