maqetta / maqetta

Maqetta Designer
http://maqetta.org
Other
1.04k stars 336 forks source link

Replace alerts and confirms with standard dialog #446

Open jmockler opened 13 years ago

jmockler commented 13 years ago

(The description below is for one such scenario in the code where we are using alert() or confirm() instead of a proper dialog. A proper dialog will allow us to style the UI to match other dialogs in the product.)

When STOPPING a review, a confirmation dialog shows up in a non-maqetta style. We should revise the text, and other details, as well as ensure that the dialog matches the Claro theme.

http://img.skitch.com/20110527-fjq4x2ay8b8h2g1k2x2ib5f92y.png

@jmockler @JonFerraiolo @EldonReturn Review and Commenting Review - May 26, 2011

peller commented 13 years ago

note that this appears to be a native window.confirm (like an alert)

jmockler commented 13 years ago

If we continue to use the native window.confirm dialog.. we should reformat the contents.

peller commented 13 years ago

native dialogs cannot be styled. all you can do is change the text which appears (not even its appearance)

EldonReturn commented 13 years ago

Currently the style R&C uses follows the page designers.

JonFerraiolo commented 12 years ago

@doronrosenberg - could you please investigate to see if this dialog was updated as part of your dialog unification effort?

doronrosenberg commented 12 years ago

I didn't convert any uses of alert() or confirm()

JonFerraiolo commented 12 years ago

Thanks. Renaming the issue to be more general. M7/Prio-Low, probably will be pushed to M8.

billreed63 commented 12 years ago

The conformation from the file palette delete is an alert box

JonFerraiolo commented 11 years ago

My current thinking is that we should have a Maqetta version of alert() and confirm() that is packaged nearly as simply as the standard browser versions of these functions.

JonFerraiolo commented 11 years ago

-> M11 Prio High - let's take care of this once and for all