search

mar-file-system / erasureUtils

Erasure coding utilities intended for the marfs multicomponent DAL. These service the creation, retrieval, and maintenance of erasure coded data stripes spread accross multiple files.
Other
4 stars 5 forks source link

File descriptor leak #10

Closed wfvining closed 7 years ago

wfvining commented 7 years ago

There is a file descriptor leak in ne_close() pointed out by Dave B.

The bug was introduced here d2e2175506ece7c06c92a4db0328e7b4bdf173f8. It effects reads and rebuilds only, writes are safe from the leak.

jti-lanl commented 7 years ago

In the event of errors, there may (conceivably) also have been some leaks via MarFS data_close() and marfs_flush(), which should be addressed by recent as-yet-uncommitted patches.

On Apr 19, 2017, at 8:53 AM, Will Vining notifications@github.com wrote:

There is a file descriptor leak in ne_close() pointed out by Dave B.

The bug was introduced here d2e2175. It effects reads and rebuilds only, writes are safe from the leak.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

wfvining commented 7 years ago

Leak resolved. Watching the number of open files during a single-threaded rebuild shows that there are never more than 12 open throughout the rebuild.