search

mar-file-system / mad

MarFS Automatic Deployment
Other
0 stars 0 forks source link

Wrap up unit tests #13

Closed shanegoff closed 4 years ago

shanegoff commented 4 years ago

Finish up the unit tests

jti-lanl commented 4 years ago

Don’t forget about the need to generate a .h file, containing C struct declarations, if the fields of the abstract XML change. Perhaps we can just do that by hand, from now on.

From: Shane Goff notifications@github.com Reply-To: mar-file-system/mad reply@reply.github.com Date: Monday, October 5, 2020 at 10:19 AM To: mar-file-system/mad mad@noreply.github.com Cc: Subscribed subscribed@noreply.github.com Subject: [EXTERNAL] [mar-file-system/mad] Wrap up unit tests (#13)

Finish up the unit tests

You can view, comment on, or merge this pull request online at:

https://github.com/mar-file-system/mad/pull/13

Commit Summary

File Changes

Patch Links:

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHubhttps://github.com/mar-file-system/mad/pull/13, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AB63N6LQ3CIGNAXX7XDJVMLSJHWZ3ANCNFSM4SE4XD4Q.

shanegoff commented 4 years ago

addresses #3

shanegoff commented 4 years ago

@jti-lanl I believe the plan for the future is to maintain static config headers for MarFS. The config structs don't change terribly often for MarFS, but I have some stuff in place that I could maybe use for generating a new header file with updated structs from python if the structs change. I used something similar to that in the early phases for rapid prototypes, it could still have value for that purpose. I'll open an issue.

jti-lanl commented 4 years ago

Your approach is probably good. Like you said, the structure isn’t changing much these days.

From: Shane Goff notifications@github.com Reply-To: mar-file-system/mad reply@reply.github.com Date: Monday, October 5, 2020 at 2:00 PM To: mar-file-system/mad mad@noreply.github.com Cc: "Inman, Jeff" jti@lanl.gov, Mention mention@noreply.github.com Subject: [EXTERNAL] Re: [mar-file-system/mad] Wrap up unit tests (#13)

@jti-lanlhttps://github.com/jti-lanl I believe the plan for the future is to maintain static config headers for MarFS. The config structs don't change terribly often for MarFS, but I have some stuff in place that I could maybe use for generating a new header file with updated structs from python if the structs change. I used something similar to that in the early phases for rapid prototypes, it could still have value for that purpose. I'll open an issue.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/mar-file-system/mad/pull/13#issuecomment-703856482, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AB63N6N6A4FEJJW2GPRUQFLSJIQV5ANCNFSM4SE4XD4Q.