mar10 / pyftpsync

Synchronize directories using FTP(S), SFTP, or file system access.
https://pyftpsync.readthedocs.io
MIT License
117 stars 25 forks source link

'new' not supported in interactive resolve in the DownloadSyncronizer #25

Closed romankor closed 6 years ago

romankor commented 6 years ago

I think there is a bug in the download syncronizer. It allows only for assert resolve in ("remote", "ask", "skip") Then what we get in the on_conflict method is :

            elif resolve == "remote" or (is_newer and resolve == "old") or \
                    (not is_newer and resolve == "new"):
                self._log_action("copy", "conflict", "*<*", pair.local)
                self._copy_file(self.remote, self.local, pair.remote)

Which clearly just copies every files again and again since i kinda need to use remote all the time

mar10 commented 6 years ago

resolve is meant to resolve a conflict situation.

Could you explain in which scenario you think there are missing options or too much copying?

mar10 commented 6 years ago

We can re-open this if I better understand the request.