search

mar4444 / re-deployment

1 stars 0 forks source link

Peer to Peer review 🚀 #3

Open evansnyamekye opened 1 year ago

evansnyamekye commented 1 year ago

Changes Required ♻️ index.html --Nice design but you need to change desktop background image 🖼️. --Good implementation of html semantic tags. --There was no comment for the styles link and alt.

styles.css --Good use of CSS entities and properties. 🔧.

Thank you. 😀.

zhorabay commented 1 year ago

Hello @mar4444

image

Good job so far! :+1: There are some issues that you still need to work on to go to the next project but you are almost there!

To Highlights

:heavy_check_mark: Excellent project work. :heavy_check_mark: Good use of GitHub flows 👍

Required Changes ♻️

Check the comments under the review.

Optional suggestions

Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.

Cheers and Happy coding!👏👏👏

https://github.com/mar4444/re-deployment/blob/efb24aa768ee0ee626bee5a453b7ca7739e46e04/index.html#L

When we fill email address field in your contact form, it accepts not only emails but any word which included @ symbol. You can use: pattern="^([a-zA-Z0-9_-.]+)@(([[0-9]{1,3}.[0-9]{1,3}.[0-9]{1,3}.)|(([a-zA-Z0-9-]+.)+))([a-zA-Z]{2,4}|[0-9]{1,3})(]?)$" in your input.

ayaderaghul commented 1 year ago

Hi, The menu button is not clickable in mobile version. Please use JS or bootstrap to make it expandable. This makes the website better. You can check for suggestion here https://getbootstrap.com/docs/4.0/components/dropdowns/

image