search

mara / mara-pipelines

A lightweight opinionated ETL framework, halfway between plain scripts and Apache Airflow
MIT License
2.07k stars 100 forks source link

PostgreSQLDB(..) constructor doesn't handle port #9

Closed bloo closed 5 years ago

bloo commented 6 years ago

Passing a port (as an int or a string) isn't honored as it runs against 5432 no matter what you pass in to the constructor.

mara_db.config.databases \
    = lambda: {'mara': mara_db.dbs.PostgreSQLDB(host='localhost', port=25432, user='etl', password='etl', database='etl')}
bloo commented 6 years ago

Follow up - this works for configuring access during run but fails during migration - it's the migration code that does not honor the port:

import mara_db.auto_migration
...
mara_db.auto_migration.auto_discover_models_and_migrate()
jankatins commented 6 years ago

There was a bug in the automigration script in mara/mara-db, which is fixed in master: https://github.com/mara/mara-db/pull/12 -> bugreport is here: https://github.com/mara/mara-db/issues/11 -> is that your error message? If so, as a workaround, please update mara-db to master. If not, please post it here so we can see whats wrong here...

martin-loetzsch commented 5 years ago

If the problem still exists, please update mara_db package