search

mara / mara-pipelines

A lightweight opinionated ETL framework, halfway between plain scripts and Apache Airflow
MIT License
2.07k stars 100 forks source link

add typing + fix small issues #91

Closed leo-schick closed 1 year ago

leo-schick commented 1 year ago

Add typing for parameters + fix several small issues in code

leo-schick commented 1 year ago

@jankatins I paid attention that I don't use all the fancy new stuff becuase we still have 3.6 as minimum requirement. I dropped 3.6 from the CI tests because it isn't anymore supported (and CI tests are not available anymore).

I often hesitate to upgrade because I don't know what people use out there. x | None requires 3.10. I am currently on 3.9 because of some package dependecies which where incompatible when I tried to upgrade the last time.

Any suggestions for a policy when we should upgrade python versions?

jankatins commented 1 year ago

I think I remember that the initial mara version had python requirement on the "latest and greatest python" :-)

Basically up to you, but my suggestion would be to at least drop anything which is not supported anymore. Given that everybody and my mother runs stuff in a docker container that shouldn't be a big problem :-)

leo-schick commented 1 year ago

@jankatins Sounds great! I think I will merge this for now and we can apply this on e.g. next major release and make python 3.11 as a minimum requirement.