marado / TalkerNode

A telnet-based talker, written in Node.js
The Unlicense
11 stars 11 forks source link

Don't wait for a .quit to save the total login time #90

Closed marado closed 4 years ago

marado commented 5 years ago

If we have an user connected for a few months without quitting and then the server crashes, or something on that kind, he will loose all that login time, since we're only saving it once the user .q's.

subhamskm commented 5 years ago

I am not able to give a name. When I press any key it gives "invalid username...." Screenshot (32)

marado commented 5 years ago

Interesting... That's new: TalkerNode used to run well on Windows, as well as deal well with Windows' telnet.

Can you please open a new issue about this? In it, please tell me which versions of both Windows and Node.js are you using.

Can you also, please, try connecting using a MUD client instead of telnet? That will help us find out if the problem is on the server running on that combination of Windows+node version, or on the server generically dealing with connecions from the telnet from that Windows version.

On Sun, Jun 30, 2019, 08:46 Subham Kumar notifications@github.com wrote:

I am not able to give a name. When I press any key it gives "invalid username...." [image: Screenshot (32)] https://user-images.githubusercontent.com/31374351/60393837-42f05a80-9b39-11e9-9951-19eadc49df45.png

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/marado/TalkerNode/issues/90?email_source=notifications&email_token=AAAIDCZSHZRUCDKQQPS5O6TP5BQGVA5CNFSM4H4KBNFKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODY4HE5Q#issuecomment-507015798, or mute the thread https://github.com/notifications/unsubscribe-auth/AAAIDC4Z5JBVERNQTVZNFWLP5BQGVANCNFSM4H4KBNFA .

marado commented 5 years ago

Also, are you by any reason using cmder to run telnet? You might be hitting on https://github.com/Maximus5/ConEmu/issues/870 ...

marado commented 5 years ago

I'm also seeing a color bleed that shouldn't be there, which leads me to believe you're using (directly or indirectly) powershell to run telnet, with the symptoms of https://github.com/PowerShell/PowerShell/issues/7767 (which would mean you're using a version older than powershell 6.2.0).

marado commented 5 years ago

I also tested using powershell 6.2.1 (on GNU/Linux, YMMV) to connect to TalkerNode and didn't reproduce your issue.

marado commented 4 years ago

Amnuts has a manual way of doing this, with .save , but maybe we can find a better approach.

dissidente commented 4 years ago

My approach would be to use a timer to periodically save the information (ie. hourly), and use the same function for both a manual save command (.save as you suggest) and the on quit saving.

marado commented 4 years ago

We can go that route, yes:

dissidente commented 4 years ago

Implemented in #107