search

maradotwebp / pax

📦 The MC modpack manager for professionals.
https://github.com/froehlichA/pax/releases/latest
MIT License
164 stars 3 forks source link

Support for curseforge resource packs #53

Closed juraj-hrivnak closed 2 years ago

juraj-hrivnak commented 3 years ago

To be able to release modpack on the CurseForge, resource pack files should be referenced in the manifest.json. Otherwise, the modpack will be rejected.

maradotwebp commented 3 years ago

Good idea! For now, you can add them manually to the manifest, but I'll add the feature later.

maradotwebp commented 3 years ago

Marked as bug, because adding a resourcepack manually breaks pax.

maradotwebp commented 3 years ago

Ok, after testing again I realised pax doesn't break anymore with a resource pack, at least not when I'm testing. If it does for you, try updating to the newest version first, if that still doesn't help, tell me about what commands are causing a crash for you.

The act of adding a resource pack with ./pax add would complicate things a bit, I'm gonna think about how to manage them a bit longer. ./pax upgrade should also work with resource packs.

juraj-hrivnak commented 3 years ago

I was exporting my modpack with the resource pack in the manifest with no problem, even on the older version of Pax. But, thanks for the info!

Running ./pax add also for resource pack could be confusing. Hard to tell how to make it. Take your time with it! Oh, that's great.