search

maradotwebp / pax

📦 The MC modpack manager for professionals.
https://github.com/froehlichA/pax/releases/latest
MIT License
161 stars 4 forks source link

Can't add mods released as alpha. #54

Closed juraj-hrivnak closed 3 years ago

juraj-hrivnak commented 3 years ago

The issue

I wanted to add this mod to my modpack: https://www.curseforge.com/minecraft/mc-mods/multithreaded-noise, but it's released as alpha, and apparently, pax won't let me do that.

$ pax add Multithreaded Noise
[:] Loading data from manifest..
[:] Searching for mod..
[x] No compatible version found.
maradotwebp commented 3 years ago

PAX should normally fallback to different version resolutions so if the "recommended" strategy cant find any files the "newest" strategy is applied, which will allow any mod files matching your modpacks major version.

This mod is 1.12, are you sure your modpacks version is set to 1.12 (or 1.12.1 or 1.12.2)?

juraj-hrivnak commented 3 years ago

Ahah, so that issue is in the Minecraft version. The modpack is set to 1.12.2. Here is my manifest.json: https://pastebin.com/UTYJ7kKq

So, the issue is that this mod also works for 1.12.2 and not only 1.12. Yeah, it's the mods fault, but it would be nice to be able to ignore the mc versions in Pax, just in case if the mod author forgets to add the newest mc version in the compatible versions.

maradotwebp commented 3 years ago

Normally Pax allows installation of mods with the same major version as the modpack, so this seems more like a bug. Ill take a look at this issue later today.

juraj-hrivnak commented 3 years ago

Thank you! I've been really enjoying using the Pax lately. It is also easy to use, just like you said. It reminds me of Node Package Manager. I really appreciate your work!

maradotwebp commented 3 years ago

Oh, I see what's going on: The curseforge search API is pure shit, and when searching for "Multithreaded noise", instead of returning the mod LITERALLY called "Multithreaded noise", it will return a mod called "Annoing mod warning loud noise", because apparently full text search is still SO difficult in 2021.

When the curseforge search API only returns one item, PAX assumes this is the mod you want and skips selecting mods out of the list, never telling you what mod it actually selected.

I can't fix the curseforge api, but I can kinda prevent users not knowing what went wrong by echoing what mod was actually selected before pax tries to install it, which could give future users at least some feedback that the wrong mod was selected.

Btw, this doesn't solve your issue of course, you'll need to add the mod with the curseforge URL:

./pax add https://www.curseforge.com/minecraft/mc-mods/multithreaded-noise

which should resolve to the correct mod.