search

maradotwebp / pax

📦 The MC modpack manager for professionals.
https://github.com/froehlichA/pax/releases/latest
MIT License
164 stars 3 forks source link

Add -v/--version, -h/--help description edit #64

Closed huantianad closed 2 years ago

huantianad commented 2 years ago

Adds a -v/--version option, which shows pax's version. (Solves #63) The version is the same as the version in pax.nimble.\ Note: Currently only implemented in spec, not each subcommand, so will only work if used with no subcommand.

Rework -h/--help option, change help description for this option from "Show help message" to "show help message" to be consistent with other help descriptions.

huantianad commented 2 years ago

Not sure why CI is failing, could be because I'm testing on nim 1.6.2

maradotwebp commented 2 years ago

No idea either why it thinks it's a void type. Either way, I think reading the version from the latest git tag is a better method, as I don't need to manually keep the package version up-to-date.

maradotwebp commented 2 years ago

Apologies for pushing directly to your pr, but would this work?

huantianad commented 2 years ago

Yeah that looks good! Only concern is building outside of a git repo clone, eg from GitHub release zips.

I was originally thinking of the AUR package, but it should be fine since I can use a git source.