search

maradotwebp / pax

📦 The MC modpack manager for professionals.
https://github.com/froehlichA/pax/releases/latest
MIT License
164 stars 3 forks source link

Github action doesn't set correct Minecraft versions. #78

Open Chaos02 opened 2 years ago

Chaos02 commented 2 years ago

I have just investigated why CF always sets the latest minecraft version for uploaded files. The Culprit is that the CF uploader (https://github.com/itsmeow/curseforge-upload@v3) is being run with the game-versions of Minecraft <extracted manifest version here>.

This is a problem since the field should contain IDs for game versions that can be extracted through the API and a slug/name consisting of the extracted manifest version. Documentation here: CurseForge

If you would like me to implement this feature, please reach out. It requries the same token in the GET-request as the upload.

Chaos02 commented 2 years ago

it could btw also add a version for the major version of minecraft aswell as the forge/fabric version being used (or just forge and fabric accordingly)

Chaos02 commented 2 years ago

correction: the correct minecraft and forge VersionID can be obtained here: https://api.curseforge.com/v1/minecraft/version/1.18.2 https://api.curseforge.com/v1/minecraft/modloader/forge-40.1.73

warezit commented 1 year ago

I'm having this issue also.

Manifest says 1.19.2. When I check CurseForge it says 1.20.2-Snapshot (since that is the most current release of MC right now). Link to my setup/repo here

Thoughts?