Closed lukeed closed 3 years ago
(force push after rebase)
The test is failing exactly because of my allows
changes. The test is changing the process.env.DEBUG
value at runtime. If this is intentional, I can revert the eager hoisting, which still puts performance around 420k to 430k op/s
Notes
fatal
level set up but not used; left TODO note for itname
orlevel
used for outputThis may be unwanted API change
allows
bit to top-level scope, so that the allowed-scopes are known at initializationThis was actually a bit perf boost within the benchmark itself (reading from
process.env
is slow actually).This may be unwanted API change
Feedback
I think your hooks API might feel a bit better if you didn't
return
within every hook; and instead just expect mutations. You can usereturn false
as a stop/bailout.I didn't add this since it would be a breaking change – previous
undefined
, even implicit ones, would cause thediary
loop to stop, whereas my suggestion would treat that as the normal case.Before
After