search

maraisr / diary

📑 Zero-dependency, fast logging library for Node, Browser and Workers
MIT License
255 stars 7 forks source link

Fix TypeScript unable to resolve types #10

Closed maxmilton closed 3 years ago

maxmilton commented 3 years ago

Fixes https://github.com/maraisr/diary/issues/9

Removes typesVersions field in package.json. If types are meant to apply to any TS version this field is not actually required.

It seams the "*" key is not getting picked up by TS correctly and that's what causes the types to be unresolved.

maraisr commented 3 years ago

Thanks for the PR @maxmilton think I may need to add a manual file to this. There are 2 sub-modules diary/utils and diary/json, both need types associated. Which is what i though that typeVersions was meant to handle.

Are you okay for me to extend your PR to include this?

maxmilton commented 3 years ago

Ah I see. Of course, go nuts :+1: