maraisr / diary

📑 Zero-dependency, fast logging library for Node, Browser and Workers
MIT License
252 stars 7 forks source link

fix: return message from child() #3

Closed gajus closed 3 years ago

gajus commented 3 years ago

Updated benchmarks:

Validation
✔ diary
✔ ulog
✔ roarr
✔ bunyan
✔ debug
✔ pino
✔ winston

Benchmark
  diary      x 661,459 ops/sec ±1.34% (91 runs sampled)
  ulog       x 22,853 ops/sec ±44.25% (9 runs sampled)
  roarr      x 749,119 ops/sec ±12.59% (86 runs sampled)
  bunyan     x 99,588 ops/sec ±24.33% (92 runs sampled)
  debug      x 222,025 ops/sec ±3.22% (88 runs sampled)
  pino       x 49,700 ops/sec ±2.49% (91 runs sampled)
  winston    x 12,532 ops/sec ±9.64% (80 runs sampled)
maraisr commented 3 years ago

Thanks for this! Those numbers look impressive! I ran this on my windows pc, and roarr is outputing log messages even though its "turned off" via .write = noop.

I can see them working in GH Actions, so could be something my end. So will leave this open till I figure out what's going on.

image

gajus commented 3 years ago
Validation
✔ diary
✔ roarr

Benchmark
  diary      x 658,573 ops/sec ±1.35% (90 runs sampled)
  roarr      x 1,170,401 ops/sec ±0.78% (93 runs sampled)

Latest numbers. :-)

Regarding the output to console.log, looks like you have somewhere locally defined global.ROARR.write method.

maraisr commented 3 years ago

WOW, now that is impressive! So good, amazing what difference Date.now had.