search

maralorn / nix-output-monitor

Pipe your nix-build output through the nix-output-monitor a.k.a nom to get additional information while building.
GNU Affero General Public License v3.0
895 stars 27 forks source link

blue foreground on black background can't be read #113

Closed novoid closed 1 year ago

novoid commented 1 year ago

Hi,

I'm having a white on black terminal setup.

As you can see in the screenshot, blue text is not readable:

2023-09-17T17 13 54 nh with blue foreground on black background -- screenshots

Maybe you can think of a solution here that doesn't involve switching to a bright color theme?

maralorn commented 1 year ago

In my opinion it is the responsibility of the terminal theme to guarantee a good contrast between the colors offered. This blue tone is not hardcode in nom it is the default blue configured in your terminal. I assume most users use nom in dark mode, I do too.

image

As you can see I even have blue on blue there, but because the terminal colors are very bright the dark background is not a problem.

I am open to suggestions but I wouldn’t know what else to do. nom restricts itself to use the 8 default colors available in the terminal so that it correctly adapts to the user color theme.

novoid commented 1 year ago

Thanks for your explanation and your screenshot.

I'm using xfce4-terminal with its default (dark) settings. I switched the setting for blue (Edit - Preferences - Colors - Palette) to a brighter one which fixes the issue for me. Maybe the xfce4-terminal defaults are causing this issue. For now, this is solved, thanks.