search

maralorn / nix-output-monitor

Pipe your nix-build output through the nix-output-monitor a.k.a nom to get additional information while building.
GNU Affero General Public License v3.0
841 stars 24 forks source link

Running in Emacs eshell crashes nom #66

Closed wolverian closed 1 year ago

wolverian commented 1 year ago 
$ nom develop

nom: divide by zero
$ nom --version
nix-output-monitor 2.0.0.2
nix (Nix) 2.11.1

I think I've seen this before with some other programs when running in a terminal that doesn't provide terminal size information or something like that. Eshell is a "dumb" terminal. Of course nom won't probably work in a dumb terminal very well in the end, but I think it shouldn't crash with a divide by zero either.

maralorn commented 1 year ago

Thank you for reporting this! nom can deal with a terminal not reporting size, but in this case the terminal reports a size of zero.

Anyway, I have audited all cases of division in the code and made sure that divisions by zero won’t happen again.

That means this issue will be resolved in the next release.