Socket is world writable

marazmista / radeon-profile-daemon

Daemon for radeon-profile GUI

GNU General Public License v2.0

119 stars 23 forks source link

Socket is world writable #18

Open devurandom opened 5 years ago

devurandom commented 5 years ago

The socket radeon-profile-daemon creates is:

Located in /tmp, while I would expect sockets of system services to be in /run
World-writable, while I would expect it to be restricted to e.g. the video group

$ sudo netstat -npl | grep radeon-profile
unix  2      [ ACC ]     STREAM     LISTENING     12415381 23656/radeon-profil  /tmp/radeon-profile-daemon-server
$ ls -l /tmp/radeon-profile-daemon-server
srwxr-xrwx 1 root root 0 Apr 23 20:43 /tmp/radeon-profile-daemon-server=

marazmista commented 5 years ago

Hi, partially implemented here ec81c14aaca4753787e7be3630d478563216bd9d, socket file moved to /run

stintel commented 3 years ago

I'm planning to submit a PR to fix this soon, I'm just waiting for permission of the author of one of the patches.

Oxalin commented 1 year ago

This is fixed under my fork, thanks to stintel code and a bit of polishing.