marazmista / radeon-profile

Application to read current clocks of ATi Radeon cards (xf86-video-ati, xf86-video-amdgpu)
GNU General Public License v2.0
733 stars 75 forks source link

Critical build error on OBS prevents radeon-profile from being packaged (and so does lack of releases) #10

Closed v-fox closed 9 years ago

v-fox commented 9 years ago

Recently I tried to make radeon-profile package for openSUSE but couldn't because OBS automatically checks the code for potential security vulnerabilities and plain weirdness. And when it finds something, it deletes the package before letting it be downloaded. Its errors in the log are like this:

[  186s] I: Program returns random data in a function
[  186s] E: radeon-profile no-return-in-nonvoid-function ../radeon-profile/dxorg.cpp:248, 362, 445, 554
[  186s] E: radeon-profile no-return-in-nonvoid-function ../radeon-profile/gpu.cpp:52, 176

It also doesn't like that {C,CXX}FLAGS are ignored by your build scripts:

[  186s] I: File is compiled without RPM_OPT_FLAGS
[  186s] W: radeon-profile no-rpm-opt-flags <cmdline>:../radeon-profile/main.cpp, ../radeon-profile/radeon_profile.cpp, ../radeon-profile/qcustomplot.cpp, ../radeon-profile/uiElements.cpp, ../radeon-profile/uiEvents.cpp, ../radeon-profile/gpu.cpp, ../radeon-profile/dxorg.cpp, ../radeon-profile/dfglrx.cpp, ../radeon-profile/settings.cpp, ../radeon-profile/daemonComm.cpp, ../radeon-profile/execTab.cpp, ../radeon-profile/execbin.cpp, qrc_radeon-resource.cpp, moc_radeon_profile.cpp, moc_qcustomplot.cpp, moc_daemonComm.cpp, moc_execbin.cpp
marazmista commented 9 years ago

I've modified some code in commit b9fc7a18429265f9084d9ddd2c6ba6a730e42121, could you try build it now?

v-fox commented 9 years ago

That did it, builds fine now, thanks !