marazmista / radeon-profile

Application to read current clocks of ATi Radeon cards (xf86-video-ati, xf86-video-amdgpu)
GNU General Public License v2.0
734 stars 75 forks source link

Don't read amdgpu_pm_info anymore #54

Closed ChristophHaag closed 7 years ago

ChristophHaag commented 7 years ago

With linux 4.12 reading this file causes stuttering in 3D apps.

See: https://bugs.freedesktop.org/show_bug.cgi?id=101182

bugz8unny69 commented 7 years ago

If and when this pull request get's merge https://github.com/marazmista/radeon-profile/pull/44. It will likely solve that issue.

Danysan1 commented 7 years ago

Actually it would not solve completely the problem (in that PR ioctls are still used together with data from amdgpu_pm_info), but it would be a step toward the solution.

ChristophHaag commented 7 years ago

Another quick fix would be reading the specific relevant files like for the frequencies /sys/class/drm/card0/device/pp_dpm_mclk and /sys/class/drm/card0/device/pp_dpm_sclk for GPUs that have powerplay support.

marazmista commented 7 years ago

@lhorace yes, I've merged that into a dev branch and I'm working on an update, although some stuff is not available in ioctls, like volts, but I guess this was removed info from amdgpu module debug info anyway, and may stay as an option when someone use radeon module.

bugz8unny69 commented 7 years ago

Great, it's been a very useful software here. Hopefully, that could fix some stability issues that I experience, that don't bother me so much.

Additionally, I don't particular care about volts, however, how about asking amdgpu developers to expose it somehow? I am certainly sure that plenty of other users would find that information useful.

marazmista commented 7 years ago

I pushed update to rp-dev branch. For amdgpu clocks info, Kernel 4.12 is a minimum because ioctls for this information are not available in earlier releases. It is still work in progress (for example, I'm having problems getting info about gpu usage on amdgpu but it is ok when I use radeon), and I want to add couple of things, but in overall, stuff should work.

If you use daemon, install updated version. Qt4 won't work and also qt5-charts package is needed.

Danysan1 commented 7 years ago

I tried compiling it but it did not work. It compiles only with the changes in https://github.com/marazmista/radeon-profile/compare/rp-dev...Danysan1:rp-dev

Danysan1 commented 7 years ago

Also, pwm speed is shown even if it is not available. This should fix it: https://github.com/Danysan1/radeon-profile/compare/rp-dev...rp-dev-2

marazmista commented 7 years ago

Ioctls are now primary data source with optional debugfs, merged ac594203b2b89001304d73c38bb3c87a4adbd4c8