search

marbl-ecosys / MARBL

Marine Biogeochemistry Library
https://marbl-ecosys.github.io
Other
13 stars 24 forks source link

Missing _r8 in constant declaration #281

Open mnlevy1981 opened 6 years ago

mnlevy1981 commented 6 years ago

In marbl_constants_mod.F90:

      epsC      =   1.00e-8,           & ! small C concentration (mmol C/m^3)
      epsTinv   =   3.17e-8,           & ! small inverse time scale (1/year) (1/sec)

and in marbl_settings_mod.F90:

       dust_Fe_scavenge_scale  = 1.0e9         !dust scavenging scale factor

And perhaps others?

mnlevy1981 commented 6 years ago

Two more examples from marbl_mod.F90, but we are fairly confident that these five are all of them:

    work = PAR_col_frac(subcol_ind) * (log(PAR_in(subcol_ind))*0.4373_r8) * (10.0e2/dz1)

and

    rate_per_sec_subcol = (log(PAR_in(subcol_ind))*0.4373_r8)*(10.0e2/dz1)*((12.0_r8/3.0_r8)*yps) ! 1/(3 months)

The changes coming in via #298 will be able to catch this type of error.

@klindsay28 notes that fixing the values in marbl_constants_mod.F90 can lead to differences that "can evolve to O(1) in some quantities in an ERI test. Perhaps this is not surprising, but before accepting these change, I think I would need to convince myself that these changes are not changing the science."