marbl-ecosys / MARBL

Marine Biogeochemistry Library
https://marbl-ecosys.github.io
Other
14 stars 25 forks source link

photoC_NO3_TOT_zint_100m diagnostic not computed #401

Open klindsay28 opened 2 years ago

klindsay28 commented 2 years ago

In recent MOM vs POP MARBL comparison runs, I noticed that photoC_NO3_TOT_zint_100m is all zeros.

Digging into the code and commit history, I see that I added a declaration for photoC_NO3_TOT_zint_100m in e7deac50, but did not add code to compute the diagnostic.

I guess we haven't looked at this diagnostic. It is not a CMIP diagnostic, while the related diagnostic photoC_NO3_TOT_zint is.

I'm not sure if we should remove photoC_NO3_TOT_zint_100m or add code to compute it.

I'm leaning towards the former, given that this issue hasn't been noticed in the 4 years since the diagnostic was added.