search

marbl-ecosys / MARBL

Marine Biogeochemistry Library
https://marbl-ecosys.github.io
Other
13 stars 21 forks source link

Updates from mom6 driver #419

Closed mnlevy1981 closed 1 year ago

mnlevy1981 commented 1 year ago

The big feature is generalizing the surface_flux_output_type so MARBL can provide the GCM with fields from interior_tendency_compute() as well as surface_flux_compute(); this new functionality is used to allow the option of returning the 3D chlorophyll field (POP only needed the surface chlorophyll, but MOM needs the 3D field).

I also added an option to check consistency in the PAR forcing field, but it is turned off by default because there is a huge performance hit.

mnlevy1981 commented 1 year ago

@klindsay28 and I reviewed this PR on March 8th; 0c46cd5, 1828803, and 75852f1 address all the small changes. The only outstanding item from the code review is that check_forcing() is triggering a ton of warnings in a C compset, and the additional output to stdout is a significant hindrance to performance. Before this is merged, we need to figure out what is going wrong with the C compset forcing; once those warnings are reduced I'll have one more commit to this PR where I remove the lcheck_forcing logical flag (we'll check the forcing every time)

mnlevy1981 commented 1 year ago

Per further discussion with @klindsay28, we're going to merge this as is and address the problems in check_forcing() separately.