marbl-ecosys / MARBL

Marine Biogeochemistry Library
https://marbl-ecosys.github.io
Other
14 stars 25 forks source link

check_forcing() is flooding stdout in CMOM compset #421

Open mnlevy1981 opened 1 year ago

mnlevy1981 commented 1 year ago

419 introduces a new function to make sure the column fractions provided by the GCM for PAR sum to 1 (within 1e-6); when turned on in a C compset testing with the MARBL driver in MOM, we are getting a ton of warnings about 1e-3 off, which is crippling performance.

The PR currently has an lcheck_forcing flag that is false by default, but once we figure out why the C compset fractions aren't adding up we should remove that flag (so we always call the function) and possibly also change the warning to an error.