search

marbl-ecosys / MARBL

Marine Biogeochemistry Library
https://marbl-ecosys.github.io
Other
14 stars 25 forks source link

Carbon isotopes don't handle explicit calcifiers correctly #434

Open mnlevy1981 opened 1 year ago

mnlevy1981 commented 1 year ago

This was a problem for a CESM experiment that wanted to use 4p1z and CISO, so there are source mods in a bunch of cases on glade. For example, see

/glade/work/jcoupe/cases/MAA_tests/MAA2.1.3_DATM_POP2_SLND_CICE4_DROF_SGLC_SWAV_f19_g16_newgrid_BGC_ciso_SPINUP_NCPL12_dt36_final/SourceMods/src.pop/

I know we want the updates to marbl_ciso_interior_tendency_mod.F90 from that directory, and I'll look at the other files in that directory to make sure they aren't related to this issue.

I will probably fix this in #430 because I want to run the call_compute_subroutines test with CISO to make sure the isotope code supports both unit systems.