search

marbl-ecosys / MARBL

Marine Biogeochemistry Library
https://marbl-ecosys.github.io
Other
14 stars 25 forks source link

Update marbl_ciso_surface_flux_mod.F90 #465

Open jlinmod opened 4 months ago

jlinmod commented 4 months ago

comment and eps_aq_g equation fix

mnlevy1981 commented 2 months ago

@jlinmod -- sorry for the delayed response. The Zhang et al. paper offers two different values for the temperature coeffficient when computing eps_aq_g. In the abstract, they use -0.0049 as you did:

zhang abstract

However, in Figure 2 they use 0.0049 as in the current version of the code:

zhang fig 2

Further, the slope of the line in Figure 2 is positive, which makes us think that the figure caption is the correct value to use.

Rather than close this PR, could you revert line 155 to drop the minus sign? I think the clean-up you did to the comments is valuable and we'd be happy to bring those changes in.