search

marbl-ecosys / feisty

Python implementation for the Fisheries Size and Functional Type model (FEISTY)
https://marbl-ecosys.github.io/feisty
MIT License
8 stars 4 forks source link

Rename size classes? #52

Open mnlevy1981 opened 1 year ago

mnlevy1981 commented 1 year ago

Instead of "small", "medium", and "large" (which gets confusing when talking about "Large Pelagic" vs "Foragers") should we use "larval", "juvenile", and "adult"? Open to other suggestions as well, but it would be really nice to drop the "small Large Pelagic" and "large Large Pelagic" terminology.

cpetrik commented 1 year ago

Hi Mike,

I guess you could change it, but then it would be inconsistent because the small forage fish are both larvae and juveniles. It would be immature forage and adult forage larval large pelagic, juvenile large pelagic, and adult large pelagic larval demersal, juvenile demersal, and adult demersal

Why are the long names (e.g. medium large pelagics) even needed in the code?

On Tue, Jun 6, 2023 at 8:13 AM Michael Levy @.***> wrote:

Instead of "small", "medium", and "large" (which gets confusing when talking about "Large Pelagic" vs "Foragers") should we use "larval", "juvenile", and "adult"? Open to other suggestions as well, but it would be really nice to drop the "small Large Pelagic" and "large Large Pelagic" terminology.

— Reply to this email directly, view it on GitHub https://github.com/marbl-ecosys/feisty/issues/52, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA5AFXMGDDA7IRHIKHNCLHLXJ5CINANCNFSM6AAAAAAY4SFBFI . You are receiving this because you are subscribed to this thread.Message ID: @.***>

mnlevy1981 commented 1 year ago

@cpetrik I think the long names are only used in the diagnostic output. I just noticed that @kristenkrumhardt has a plot titled "Total large large pelagic fish" in her poster, which reminded me that this has come up a few times. It's a bummer that one size class encompasses both larval and juvenile foragers, that definitely adds a layer of difficulty to changing the naming scheme.

cpetrik commented 1 year ago

@mnlevy1981 , for diagnostic names, I would go with: immature forage fish, mature forage fish, larval large pelagic fish, juvenile large pelagic fish, adult large pelagic fish, larval demersal fish, juvenile demersal fish, and adult demersal fish. In the code, there should be 3 size classes (small, medium, large) and two maturity classes (immature, mature).