marbl / MetagenomeScope

Visualization tool for (meta)genome assembly graphs
https://marbl.github.io/MetagenomeScope/
GNU General Public License v3.0
24 stars 8 forks source link

Alternate, more intuitive representation of duplicate bubble boundary nodes #206

Open fedarko opened 3 years ago

fedarko commented 3 years ago

Idea from Mihai: change the shapes -- so rather than showing two pentagons, one node is a triangle and the other one is a square (so it's still two nodes, but it looks like one node split up).

There are two cases to consider here:

  1. This node is oriented fwd: set the "first" duplicate to a square/rectangle □ and the second one to a triangle facing right ▷
  2. The node is oriented rev: set the "first" duplicate to a triangle facing left ◁ and the second one to a square/rectangle □

Another, related thing: I think we should adjust these nodes' sizes so that each of the duplicates has the area / dimensions of a node with exactly half of its length. This makes sense intuitively, although it might be annoying to rework the python code to make this happen.

Anyway, from here, everything is the same (and now we don't need to worry about that garish shade of pink) (garish is a good word).

If we eventually get to the point of using different node shapes (e.g. arrows -- see #211) then we can adjust the different shapes used here accordingly.

Checklist