search

marblejs / marble

Marble.js - functional reactive Node.js framework for building server-side applications, based on TypeScript and RxJS.
https://marblejs.com
MIT License
2.15k stars 69 forks source link

Error [ERR_PACKAGE_PATH_NOT_EXPORTED] when using rxjs v7 #324

Closed brielov closed 2 years ago

brielov commented 3 years ago

Describe the bug It seems that rxjs version 7 breaks something inside marble.

To Reproduce

yarn add @marblejs/core fp-ts rxjs

Run the example as shown on the website

Desktop (please complete the following information):

The following error is thrown:

Error [ERR_PACKAGE_PATH_NOT_EXPORTED]: Package subpath './internal/scheduler/AsyncScheduler' is not defined by "exports" in 'node_modules/rxjs/package.json'

JozefFlakus commented 3 years ago

In order to have a compatibility with latest RxJS release we have to bump the framework to the next major version - 4.0. Please confirm my thoughts.

brielov commented 3 years ago

I don't know how much RxJS has changed under the hood. If I'm not mistaken, they have renamed some operators which may cause current marble applications to break. So, I think I agree with you on bumping marble's version to 4.0.

FredericEspiau commented 3 years ago

RxJs a changed a lot between 6 and 7 so yeah, it would require a major version

JozefFlakus commented 3 years ago

In progress 🙃 https://github.com/marblejs/marble/discussions/330#discussioncomment-872200

JozefFlakus commented 2 years ago

Closing because RxJS v7 support is added in the v4.0 release candidate.