marblejs / marble

Marble.js - functional reactive Node.js framework for building server-side applications, based on TypeScript and RxJS.
https://marblejs.com
MIT License
2.15k stars 73 forks source link

fix(http): correctly calculate `Content-Length` for an empty object #355

Closed JozefFlakus closed 3 years ago

JozefFlakus commented 3 years ago

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No
codecov[bot] commented 3 years ago

Codecov Report

Merging #355 (cf21d4b) into next (46befd6) will decrease coverage by 0.59%. The diff coverage is 93.61%.

Impacted file tree graph

@@            Coverage Diff             @@
##             next     #355      +/-   ##
==========================================
- Coverage   94.91%   94.31%   -0.60%     
==========================================
  Files         135      157      +22     
  Lines        2242     3080     +838     
  Branches      301      357      +56     
==========================================
+ Hits         2128     2905     +777     
- Misses        110      171      +61     
  Partials        4        4              
Impacted Files Coverage Δ
packages/core/src/logger/logger.interface.ts 100.00% <ø> (ø)
packages/core/src/operators/use/use.operator.ts 50.00% <ø> (-50.00%) :arrow_down:
packages/http/src/error/http.error.effect.ts 100.00% <ø> (ø)
packages/http/src/http.interface.ts 100.00% <ø> (ø)
packages/http/src/index.ts 0.00% <0.00%> (ø)
packages/http/src/router/http.router.matcher.ts 100.00% <ø> (ø)
...messaging/src/transport/strategies/tcp.strategy.ts 0.00% <0.00%> (ø)
packages/middleware-cors/src/applyHeaders.ts 100.00% <ø> (ø)
packages/middleware-cors/src/checkOrigin.ts 100.00% <ø> (ø)
packages/middleware-cors/src/configureResponse.ts 100.00% <ø> (ø)
... and 158 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f7df9f9...cf21d4b. Read the comment docs.