search

marblejs / marble

Marble.js - functional reactive Node.js framework for building server-side applications, based on TypeScript and RxJS.
https://marblejs.com
MIT License
2.15k stars 73 forks source link

refactor(websockets): #broadcastEvent / #emitEvent #359

Closed JozefFlakus closed 3 years ago

JozefFlakus commented 3 years ago

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the new behavior?

Does this PR introduce a breaking change?

[x] Yes
[ ] No
codecov[bot] commented 3 years ago

Codecov Report

Merging #359 (04a7e25) into next (46befd6) will decrease coverage by 0.83%. The diff coverage is 93.05%.

Impacted file tree graph

@@            Coverage Diff             @@
##             next     #359      +/-   ##
==========================================
- Coverage   94.91%   94.08%   -0.84%     
==========================================
  Files         135      159      +24     
  Lines        2242     3110     +868     
  Branches      301      356      +55     
==========================================
+ Hits         2128     2926     +798     
- Misses        110      180      +70     
  Partials        4        4
Impacted Files Coverage Δ
packages/core/src/logger/logger.interface.ts 100.00% <ø> (ø)
packages/core/src/operators/use/use.operator.ts 50.00% <ø> (-50.00%) :arrow_down:
packages/http/src/error/http.error.effect.ts 100.00% <ø> (ø)
packages/http/src/http.interface.ts 100.00% <ø> (ø)
packages/http/src/index.ts 0.00% <0.00%> (ø)
packages/http/src/router/http.router.matcher.ts 100.00% <ø> (ø)
...messaging/src/transport/strategies/tcp.strategy.ts 0.00% <0.00%> (ø)
packages/middleware-cors/src/applyHeaders.ts 100.00% <ø> (ø)
packages/middleware-cors/src/checkOrigin.ts 100.00% <ø> (ø)
packages/middleware-cors/src/configureResponse.ts 100.00% <ø> (ø)
... and 162 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9c3d587...04a7e25. Read the comment docs.