search

marblejs / marble

Marble.js - functional reactive Node.js framework for building server-side applications, based on TypeScript and RxJS.
https://marblejs.com
MIT License
2.15k stars 73 forks source link

refactor(messaging): deprecated event bus and messaging client aliases #375

Closed JozefFlakus closed 3 years ago

JozefFlakus commented 3 years ago

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[x] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: resolves #373

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No
codecov[bot] commented 3 years ago

Codecov Report

Merging #375 (b3d5d11) into master (cbdffda) will decrease coverage by 1.34%. The diff coverage is 92.40%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #375      +/-   ##
==========================================
- Coverage   95.41%   94.07%   -1.35%     
==========================================
  Files         157      159       +2     
  Lines        2769     3103     +334     
  Branches      366      428      +62     
==========================================
+ Hits         2642     2919     +277     
- Misses        123      180      +57     
  Partials        4        4
Impacted Files Coverage Δ
packages/core/src/logger/logger.interface.ts 100.00% <ø> (ø)
packages/core/src/operators/index.ts 100.00% <ø> (ø)
packages/core/src/operators/use/use.operator.ts 50.00% <ø> (-50.00%) :arrow_down:
packages/http/src/http.interface.ts 100.00% <ø> (ø)
packages/http/src/index.ts 0.00% <0.00%> (ø)
packages/http/src/router/http.router.combiner.ts 92.30% <ø> (ø)
packages/http/src/router/http.router.matcher.ts 100.00% <ø> (ø)
...ages/http/src/router/http.router.params.factory.ts 100.00% <ø> (ø)
packages/http/src/server/http.server.interface.ts 100.00% <ø> (ø)
packages/messaging/src/reply/reply.ts 100.00% <ø> (ø)
... and 139 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 0d12706...b3d5d11. Read the comment docs.