search

marc-97 / pe

0 stars 0 forks source link

Size not accepting decimal value #5

Open marc-97 opened 3 years ago

marc-97 commented 3 years ago

As some shirt, shoes or other garments may contain a size with .5 increment for e.g 8.5, 9.5 for shoes. Disallowing the decimal value will bring inconvenience to the user. image.png

nus-pe-bot commented 3 years ago

Team's Response

It is listed in the UG, that size should be a positive integer.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Wrong error message for when size contain decimal.

Misleading error message as size is a number between 0 and 200. Should phrase the error message to something like size no. should contain only INTEGER numbers .... image.png

[original: nus-cs2103-AY2021S2/pe-interim#1630] [original labels: severity.Low type.FunctionalityBug]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

In the UG it is listed that only positive indexes can be used for the size values.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: This is an separate issue with the other bug. The 'Original' bug is pertaining to the wrong error message. However, this is marked as a feature flaw as garments commonly contain size with .5 increment. Disallowing .5 will result in a large portion of user's garment not being able to add into the app, hence not meeting the user requirement.

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: As mentioned, garments commonly have size with xx.5, for example shoes size with 8.5, shirt size with 17.5. Such limitation will result in large portion of user's wardrobe not able to be added into the app, hence not meeting user requirement.

:question: Issue type

Team chose [type.FunctionalityBug] Originally [type.FeatureFlaw]

Reason for disagreement: This is mark as a feature flaw as garments usually contains size with xx.5. Hence such limitation will disallow users to add a portion of their wardrobe in the app, hence the feature can be considered as 'incomplete' and will not be able to meet the user requirement.