search

marc-hugh-tom / ship

1 stars 0 forks source link

Unify styling #14

Open tomcraven opened 8 years ago

tomcraven commented 8 years ago

There are a few styling inconsistencies, e.g. camelcase vs underscore. Think it may have been my fault, we should agree on a standard and unify the code base to it.

Maybe in scope of this issue should be sorting out the growing __parameters block in game.js

marc-jones commented 8 years ago

It doesn't bother me, I tend to chop and change quite a bit but find underscores generally easier to read.

What do you mean by sort it out?

tomcraven commented 8 years ago

Sort out - i mean it's growing with the more functionality we add to game.js, maybe not a bad thing? I'm a little worried that game.js is going to get huge at some point but we can address that down the line!

Let's go with underscores moving forward, i'll spend some time going through the code base and making it consistent

marc-jones commented 8 years ago

I guess we could put the parameters in a separate file and import them as an object? While we're still tweaking things, though, it's convenient to have everything in a single file.