editor jumps while editing plantuml block

marc0l92 / joplin-plugin-plantUML

Render PlantUML diagram inside your Joplin notes.

MIT License

47 stars 8 forks source link

editor jumps while editing plantuml block #9

Closed kdtp closed 2 years ago

kdtp commented 2 years ago

Joplin 2.7.15 (prod, darwin) Sync Version: 3 Profile Version: 41 Keychain Supported: Yes Revision: 8352e23

PlantUML2 v1.9.0 Editor: VIM

While editing in split view, the editor view jumps away from current cursor position. Often the cursor is even outside the current view.

In the attached movie you see me inserting and deleting just a space.

https://user-images.githubusercontent.com/78899531/159061571-e4eb6c1d-03af-4dd9-8e92-26982bf3cc66.mov

marc0l92 commented 2 years ago

Hello, thanks for reporting this issue. Can you attach an example of note that I can use to reproduce the issue?

Animation

bekicot commented 2 years ago

@marc0l92

asdf
asdf
asdf
asdfasdf
asdf
asdf
asdf
asdf
asdf

```plantuml
node -- node1
node1 -- node2
node2 -- node3
node3 -- node4
node4 -- node5
node5 -- node6
node6 -- node7
node7 -- node8
node8 -- node9
node9 -- node10

node9 -- node10

The diagram needs to be higher than the viewing area.

The quick solution is: Allow disabling auto rendering. manually press button to render diagram or Dont render too quick, e.g render every 20 second is fine. If possible make it configurable.

Anyway, i may be able to make a pull request if you like the solution.

marc0l92 commented 2 years ago

I managed to fix the example you provided me, but you need to help me doing some more tests. Please let me know if the new version 1.10.0 is able to the issue you reported.