Closed marcus-crane closed 2 years ago
Oops, it just occurred to me that I should have used a dummy Jira project but ah well, nothing too interesting to see 😅
Thanks for your investigation on mobile platform. I would like to change a bit your implementation in order to use the deprecated function btoa only if the platform where the plugin is running is mobile.
I will decline your pull request and do the same changes with this additional check.
No worries! Glad to be able to use this plugin on mobile officially 🙂
Closes #9
This PR switches out the usage of
Buffer
, a Node.js standard library module with the more widely availablebtoa
which is available in every browser.I originally went down the path of trying to use a buffer polyfill but try as I might, I couldn't actually get the module's code to be bundled into
main.js
as it does withmoment
for example.I will note that Node.js has marked
btoa
as deprecated in favour ofBuffer
:The key bits here are probably
and
As scary as the message sounds, it does imply that
btoa
is fine to use if your use case is not strictly bound to Node.js which this plugin isn't really.Anyway, it works for now regardless. It's probably worth investigating if there's something better down the line.
The next thing after this will be looking at the mobile table formatting since they're quite wide 😅
Before: Issues fail to load on iOS
After: Issues load on iOS