marc0l92 / obsidian-jira-issue

This plugin allows you to track the progress of Atlassian Jira issues from your Obsidian notes.
https://marc0l92.github.io/obsidian-jira-issue/
GNU Affero General Public License v3.0
225 stars 35 forks source link

[Bug] Unable to load icons for JIRA ticket #49

Closed maxgohfp closed 1 year ago

maxgohfp commented 1 year ago

Describe the bug Firstly, thanks for creating this plugin. I love it. However, I'm creating errors when loading the icon of the ticket.

Screenshot 2022-12-28 at 3 20 40 PM

I traced through developer logs. It does seem like there's a permission issue as I tried to open the link via incognito on my browser, and there's an additional layer of authentication prior to accessing the static image. Is there a workaround that I can do?

In the network logs, I'm getting status code 302, with the response "Failed to load response data: No content available because this request was redirected".

Perhaps, I can add some static icons locally? I don't really care about the icons, but it's an eye sore when viewing through my notes.

To Reproduce Steps to reproduce the behavior:

  1. Just type JIRA:Ticket-123

Expected behavior I expect the ticket to load the correct icon properly.

Screenshots If applicable, add screenshots to help explain your problem.

Plugin version and platform

Rosswell commented 1 year ago

im experiencing the same issue - if its not fixable due to permissions, perhaps an alternative would be to allow users to select the shown columns for the inline issues, as is the case with the table view?

more detail beyond the 302 redirect: looks like its due to SSO/SAML CORB goodness, for me at least -

Cross-Origin Read Blocking (CORB) blocked cross-origin response https://companyDomain.login.duosecurity.com/email_first?authkey=blahblah&aid=blahblah with MIME type text/html. See https://www.chromestatus.com/feature/5629709824032768 for more details.

from this bit: https://github.com/marc0l92/obsidian-jira-issue/blob/master/src/client/jiraClient.ts#L34

i believe its related to this: https://jira.atlassian.com/browse/JRASERVER-72378 the icon urls are not rest apis, so passing the bearer token auth doesn't do anything, and it attempts to redirect to sso login. sigh

hilsonp commented 1 year ago

Indeed, I get the same issue. Having a way to hide the broken icon if it is not possible to work-around the problem would be nice.

maxgohfp commented 1 year ago

As a workaround, I went into the compiled main.js and removed the column from the code. It looks much more appropriate now without the icons.

I can share what I change when I get sometime later if necessary.

Screenshot 2023-02-27 at 4 43 56 PM
marc0l92 commented 1 year ago

Hello, please update the plugin to version 1.54.0. It should hide the images that I'm not able to fetch. Since I cannot test it, let me know how it looks like