search

marc0l92 / obsidian-jira-issue

This plugin allows you to track the progress of Atlassian Jira issues from your Obsidian notes.
https://marc0l92.github.io/obsidian-jira-issue/
GNU Affero General Public License v3.0
239 stars 38 forks source link

Issues are not rendered on iOS due to Buffer not being available #9

Closed marcus-crane closed 2 years ago

marcus-crane commented 2 years ago

Hi there,

I use this plugin on my desktop but I also use Obsidian on mobile and presumably the mobile version doesn't have access to a module that is available on desktop.

From memory, Buffer is part of the Node standard library so perhaps there needs to be a polyfill for the mobile version.

I haven't done much with Obsidian plugins yet but I know enough about Node that I'm happy to try and debug this myself and file a PR 🙂

60A3F8FD-20A3-4F77-A835-E002498A91CD

marcus-crane commented 2 years ago

Took me a bit to figure out how to test this stuff on mobile (I used https://github.com/TfTHacker/obsidian42-brat) but I got a fix working that I've PRed 🙂

marcus-crane commented 2 years ago

The plugin works really well on mobile after this fix. I reduced the table to 3 columns (that's all I care about) which is about the maximum size the non-responsive table can get before it's as wide as the screen. The issue there is just that the whole page overflow out of the viewport instead of the table being forced into a scrollable state.

marc0l92 commented 2 years ago

I implemented the fix in version 1.11.0 Please test it and let me know your feedbacks.

I will also test a bit more the UI on mobile in order to implement an horizontal scrolling

marcus-crane commented 2 years ago

Just updated the plugin on mobile and yep, it continues to work just as you'd expect so marking this issue as closed. Thanks again!