search

marc1706 / phpbb3-ext-quickedit

A quickedit extension for phpBB 3.1.
GNU General Public License v2.0
6 stars 7 forks source link

In full editor and preview page - "Lock topic" the box is checked #64

Closed Galixte closed 9 years ago

Galixte commented 9 years ago

Hi,

after your changes, when i go on topic if i click on edit button, the quickedit appears, if i click on "Full editor & previw" button i have the full editor page and on this page the "Lock topic" box is checked.

marc1706 commented 9 years ago

I have tried this for the first post of a topic and subsequent posts and I'm not able to reproduce this behavior for an unlocked topic.

Galixte commented 9 years ago

I have used an admin user and moderator user for my tests and i have always the same results (like first message here).

Any post on a topic:

marc1706 commented 9 years ago

Just to confirm that there is nothing else interfering: Do you have any other extensions installed?

Galixte commented 9 years ago

I have two forums on phpBB 3.1.3, the first with a lot of extensions. And second with only one extension: Quickedit.

The first forum has the same results than the second forum except this: "I click on edit button for my last post = i'm always forwarded on the full editor text page (why ? i don't know)"

This "bug" above (the first click on edit button will show me the full editor text page concerns my first forum with a lot of extension). I suspect the extension Quickreply: https://github.com/Tatiana5/QuickReply

EDIT: Quickreply extension is the problem about "i'm always forwarded on the full editor text page" (when his AJAX feature is activated). About the problem - "lock topic" box checked - i guess it's Quickedit extension that has a problem.

marc1706 commented 9 years ago

I just tried this on a vanilla phpBB 3.1.3 with only quickedit installed. I create a new topic and left it unlocked. Afterwards, I created a new post. Clicking on quickedit and submitting the form does not lock the topic. Clicking on edit after having used quickedit and then opening the full editor does not show the topic locked for me.

Galixte commented 9 years ago

On my vanilla phpBB 3.1.3 i'm have the same problem. The only difference on your forum between you and me it's the default language used, for me it's the french language. Is this a possible solution ?

EDIT: I do not think but I prefer to check: Does phpBB provides a feature to lock each subject where one edits a message?

marc1706 commented 9 years ago

You mean just locking the post instead of the topic?

Galixte commented 9 years ago

No, the entire topic.

Galixte commented 9 years ago

I come back to you, because after doing some tests (the same as you) on local and i have the same results as me (on my two online forums).

Only two options have been modified:

The only differences with you:

Others informations: My online forums are on server with Apache 2.2 / php5.5 / mysql 5.6 My local forum is on server with Apache 2.2 / php5.4 / mysql 5.6

EDIT: I have tested your extension version here: https://www.phpbb.com/customise/db/extension/quickedit/ and it does not have this problem. But on your gitHub this extension version https://github.com/marc1706/phpbb3-ext-quickedit/archive/master.zip has this problem.

EDIT 2: Here on the master branch, i have searched the commit concerned by this problem and it's this: https://github.com/marc1706/phpbb3-ext-quickedit/commit/0c22f70b6eefdf016e89ac04872bf1bd8c76d2ec The modification in event/listener_helper.php

The addition of this line:

+           'lock_topic'            => $this->not_empty_or_default($event['post_data']['topic_status'], 1, 0),
marc1706 commented 9 years ago

Just to confirm, if you remove this a locked topic will be unlocked upon quickediting it, right?

Galixte commented 9 years ago

Yes ;)

Galixte commented 9 years ago

Hi,

thanks for your PR #65 that fixes this issue !