search

marc1706 / phpbb3-ext-quickedit

A quickedit extension for phpBB 3.1.
GNU General Public License v2.0
6 stars 7 forks source link

phpBB 3.2: QuickEdit not working #83

Closed Crizz0 closed 7 years ago

Crizz0 commented 7 years ago

The extension is installable in phpBB 3.2.0. But when you click on the edit button, you'll get redirected to the the "standard" posting-editor. The quick-editor does not open.

Maybe the JS is not finding the relevant element to trigger the quick-edit-editor.

marc1706 commented 7 years ago

That will most probably be it. I guess the font awesome changes are the cause for this.

Crizz0 commented 7 years ago

Ah, the edit-button no-longer has the class "edit-icon", it does not have a special class at all, compared to the other post-buttons.

Maybe the "title" attribute is grabable, or the href=

Galixte commented 7 years ago

Hi @marc1706,

is it possible to have a fix, please ?

Crizz0 commented 7 years ago

@Galixte Try my PR #84 please.

Wedmer commented 7 years ago

This fix perfectly works on vanilla 3.2

Galixte commented 7 years ago

Thanks !

Crizz0 commented 7 years ago

Fixed in master via #84