search

marc1706 / phpbb3-ext-quickedit

A quickedit extension for phpBB 3.1.
GNU General Public License v2.0
6 stars 7 forks source link

Add lock_post to add_hidden_fields #88

Closed Crizz0 closed 3 years ago

Crizz0 commented 4 years ago

Fixes #86

I am not sure, how I should add the tests and if i need to change something in: https://github.com/marc1706/phpbb3-ext-quickedit/blob/259079d49f9c99e9c6bb4daa7fa16faf4c9648a9/event/listener_helper.php#L170 as well.

Crizz0 commented 4 years ago

@Galixte Try it. :)

Galixte commented 4 years ago

@Crizz0, Thanks I will test it now.

Galixte commented 4 years ago

@Crizz0 Perfect it works, thanks my hero!

Regards & take care of yourself.

Crizz0 commented 4 years ago

Mhm, need to recheck it and see, if i can fix it.

Galixte commented 4 years ago

Mhm, need to recheck it and see, if i can fix it.

Thanks for your help. ;)

marc1706 commented 4 years ago

@Galixte can you test this again?

Galixte commented 4 years ago

@marc1706 yes I’ll do it tonight, thanks.

Crizz0 commented 4 years ago

@marc1706 It has still the problem, that for every post now, the checkbox for Lock post [Prevent editing] is checked, does not matter if this is true or not.

marc1706 commented 4 years ago

Better? :)

Crizz0 commented 4 years ago

Better? :)

Japp, lgtm

Crizz0 commented 4 years ago

Push da merge button? or some more changes needed?