marc2332 / freya

Cross-platform GUI library for 🦀 Rust powered by 🧬 Dioxus and 🎨 Skia.
https://freyaui.dev/
MIT License
1.33k stars 51 forks source link

fix: Support alpha channel in AnimColor #771

Closed marc2332 closed 1 month ago

marc2332 commented 1 month ago

Closes https://github.com/marc2332/freya/issues/770 Depends on https://github.com/marc2332/freya/pull/768

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 92.85714% with 1 line in your changes missing coverage. Please review.

Project coverage is 73.64%. Comparing base (5b0981e) to head (86c0ed0).

Files Patch % Lines
crates/hooks/src/use_animation.rs 92.85% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## fix/element-rendering-rethink #771 +/- ## ============================================================== Coverage 73.63% 73.64% ============================================================== Files 200 200 Lines 20487 20498 +11 ============================================================== + Hits 15086 15096 +10 - Misses 5401 5402 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Aiving commented 1 month ago

Despite the support of the alpha channel in as_string, it still does not animate, since the is_finished and advance functions do not use or change the alpha channel

https://github.com/marc2332/freya/blob/fe3f4d35af1d6c2a3b0b5756494096c176ea5f3d/crates/hooks/src/use_animation.rs#L199-L249

marc2332 commented 1 month ago

Despite the support of the alpha channel in as_string, it still does not animate, since the is_finished and advance functions do not use or change the alpha channel

https://github.com/marc2332/freya/blob/fe3f4d35af1d6c2a3b0b5756494096c176ea5f3d/crates/hooks/src/use_animation.rs#L199-L249

oh man, let me fix that

marc2332 commented 1 month ago

Despite the support of the alpha channel in as_string, it still does not animate, since the is_finished and advance functions do not use or change the alpha channel

https://github.com/marc2332/freya/blob/fe3f4d35af1d6c2a3b0b5756494096c176ea5f3d/crates/hooks/src/use_animation.rs#L199-L249

Fixed, I think