marc2332 / freya

Cross-platform GUI library for 🦀 Rust powered by 🧬 Dioxus and 🎨 Skia.
https://freyaui.dev/
MIT License
1.33k stars 51 forks source link

feat: Rethink parsing #785

Open Aiving opened 1 month ago

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 79.63526% with 134 lines in your changes missing coverage. Please review.

Project coverage is 73.36%. Comparing base (3cab622) to head (83a0276).

Files Patch % Lines
crates/state/src/values/font.rs 15.15% 56 Missing :warning:
crates/state/src/lexing.rs 81.25% 24 Missing :warning:
crates/state/src/font_style.rs 17.64% 14 Missing :warning:
crates/state/src/parsing.rs 82.85% 12 Missing :warning:
crates/state/src/values/color.rs 94.44% 5 Missing :warning:
crates/state/src/style.rs 42.85% 4 Missing :warning:
crates/state/src/values/gradient.rs 94.36% 4 Missing :warning:
crates/state/src/values/overflow.rs 55.55% 4 Missing :warning:
crates/state/src/values/size.rs 90.90% 4 Missing :warning:
crates/state/src/values/fill.rs 75.00% 2 Missing :warning:
... and 4 more
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #785 +/- ## ========================================== - Coverage 73.80% 73.36% -0.45% ========================================== Files 201 202 +1 Lines 21533 21630 +97 ========================================== - Hits 15893 15868 -25 - Misses 5640 5762 +122 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Aiving commented 1 month ago

Having to write

let mut parser = Parser::new(Lexer::parse(value));

every time in the node states is a step back, why aren't those using parse_value?

I forgot to change the node states code when I added the parse_value, will make fix commit soon

Aiving commented 1 month ago

@marc2332 done

marc2332 commented 1 month ago

Can you make sure that all the examples run just fine @Aiving ?

marc2332 commented 1 month ago

Can you make sure that all the examples run just fine @Aiving ?

You may do this by running the examples.sh script

Aiving commented 1 month ago

Can you make sure that all the examples run just fine @Aiving ?

You may do this by running the examples.sh script

oki, i'll try

marc2332 commented 2 weeks ago

Conflicts @Aiving

Aiving commented 2 weeks ago

Conflicts @Aiving

resolved!

marc2332 commented 21 hours ago

We need to make sure no example broke