Open Aiving opened 1 month ago
Having to write
let mut parser = Parser::new(Lexer::parse(value));
every time in the node states is a step back, why aren't those using
parse_value
?
I forgot to change the node states code when I added the parse_value
, will make fix commit soon
@marc2332 done
Can you make sure that all the examples run just fine @Aiving ?
Can you make sure that all the examples run just fine @Aiving ?
You may do this by running the examples.sh
script
Can you make sure that all the examples run just fine @Aiving ?
You may do this by running the
examples.sh
script
oki, i'll try
Conflicts @Aiving
Conflicts @Aiving
resolved!
We need to make sure no example broke
Codecov Report
Attention: Patch coverage is
79.63526%
with134 lines
in your changes missing coverage. Please review.Additional details and impacted files
```diff @@ Coverage Diff @@ ## main #785 +/- ## ========================================== - Coverage 73.80% 73.36% -0.45% ========================================== Files 201 202 +1 Lines 21533 21630 +97 ========================================== - Hits 15893 15868 -25 - Misses 5640 5762 +122 ```:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.