search

marc3linho / OrangeClock

OrangeClock displays moscow time (sat/$)
MIT License
79 stars 13 forks source link

[BUG]fees character size too large for high fee environment #62

Open corn007 opened 5 months ago

corn007 commented 5 months ago

Describe the bug A clear and concise description of what the bug is.

To Reproduce Steps to reproduce the behavior:

  1. Walk to your 'orangeclock'
  2. Look at the fee field when fees are in three digit highs.
  3. Fail to see what the recommended high fee is
  4. Experience fail

Expected behavior See all the fee data, even if the fees are in 4 digit highs for all priorities.

Screenshots Will add screenshots IMG_9307

Additional context Add any other context about the problem here.

jdlcdl commented 5 months ago

Since last friday at 4th halving my OrangeClock was failing, unrecoverable, because writing pixels off the screen was an uncaught exception. Since then, I'm playing with pr61 which reduces what will be displayed in the fees row to avoid this, as well playing with two other prs 57 and 56 which log exceptions (so they can be seen after the fact) and which wraps requests for data in object instances that are a bit more recoverable when a site doesn't respond or responds with errors. These can be tested via combined pr60 below if you like; otherwise other devs and maintainer are aware and working towards a fix asap.

https://github.com/marc3linho/OrangeClock/pull/60

I notice that your clock is a different version I have not yet seen. I see fiat price in the blockheight row, remnants of a splash with an OrangeClock icon and logo, and your version (most interestingly to me) isn't unrecoverably-failing when trying to display that high 250-259 sat/vbyte fee. If you have a link to the version you're using, I'd be appreciative for the chance to see how that was handled. I think a recoverable but unreadable display is preferable to failing to displaying anything at all and then ending up in setup mode; instead of just looping around until all fees are visible again.

marc3linho commented 5 months ago

Thank you for opening that issue. I guess the Version @corn007 is using is @dsbaars ESP32 implementation of OrangeCock (https://github.com/btclock/OrangeBTClock). But as @jdlcdl mentioned it will be fixed soon on the OrangeClock main branch.