marcan / blitzloop

Open source karaoke software
GNU General Public License v2.0
207 stars 31 forks source link

play.py as standalone blitzloop player, with fixed keyboard handling #12

Closed yacoob closed 8 years ago

yacoob commented 8 years ago

Type of the variable used to pass the key pressed has changed from str to bytes.

Please merge after https://github.com/marcan/blitzloop/pull/11.

yacoob commented 8 years ago

Allright, this PR now fixes keyboard handling in play.py as well. Ready for review.

yacoob commented 8 years ago

Allright, this PR contains the changes from https://github.com/marcan/blitzloop/pull/13 as well, as the diff was minimal. Merge after https://github.com/marcan/blitzloop/pull/11.

marcan commented 8 years ago

Can you rebase? Looks like GitHub hasn't yet figured out that the other PR was merged.

yacoob commented 8 years ago

Should be OK now.