marcan / takeover.sh

Wipe and reinstall a running Linux system via SSH, without rebooting. You know you want to.
Other
7.1k stars 353 forks source link

Make shellcheck happy #2

Closed szepeviktor closed 7 years ago

szepeviktor commented 7 years ago
marcan commented 7 years ago

I don't use shellcheck and this isn't intended as some kind of golden shellscript you can just use as-is. You're expected to understand and modify it as needed. Given that, and that none of the changes here seem to fix actual bugs or significantly improve style, I don't see the point in making it conform to an arbitrary linter's standard.

szepeviktor commented 7 years ago

an arbitrary linter

What linter would you suggest for all of my shell scripts?

marcan commented 7 years ago

Whichever one you like, I just don't see why a random script you found on github (especially one as trivial as this) has to make it happy :-)

szepeviktor commented 7 years ago

Whichever one you like

I would really love to know what linter you find helpful.

The only bash linter I know is shellcheck. Up to now I use it before committing a script.

marcan commented 7 years ago

I do not personally use a linter for shellscripts.

szepeviktor commented 7 years ago

Thanks.